Isolate module submodule

Descent3/osiris_dll.h

@@ -112,11 +112,10 @@
 #ifndef __OSIRIS_H_
 #define __OSIRIS_H_
 
-#include "pstypes.h"
+#include "cfile.h"
+#include "module.h"
 #include "object_external_struct.h"
 #include "osiris_share.h"
-#include "module.h"
-#include "cfile.h"
 
 extern uint32_t Osiris_game_checksum;
 extern tOSIRISModuleInit Osiris_module_init;

Descent3/sdlmain.cpp

@@ -55,6 +55,10 @@
 #include "dedicated_server.h"
 #include "init.h"
 
+#ifdef WIN32
+#include "debug.h"
+#endif
+
 std::filesystem::path orig_pwd;
 
 static volatile char already_tried_signal_cleanup = 0;

Descent3/tests/CMakeLists.txt

@@ -7,6 +7,7 @@ add_executable(
 
 target_link_libraries(
   porting-tests
+  module
   GTest::gtest_main
 )
 

lib/directplay.h

@@ -44,8 +44,11 @@
 #ifndef _OUTRAGE_DIRECTPLAY_HEADER
 #define _OUTRAGE_DIRECTPLAY_HEADER
 
+#include <cstdint>
+
 #include "dplay.h"
 #include "dplobby.h"
+#include "networking.h"
 
 struct modem_list {
   char name[200];
@@ -80,7 +83,7 @@ int dp_DirectPlaySend(network_address *who_to, uint8_t *data, int len, bool reli
 void dp_DirectPlayDispatch();
 
 // Initialize stuff
-int dp_InitDirectPlay(char *conn_name, void *parms = NULL, int num_elements = 0);
+int dp_InitDirectPlay(char *conn_name, void *parms = nullptr, int num_elements = 0);
 
 // Shutdown things
 void dp_ShutdownDirectPlay();

module/CMakeLists.txt

@@ -1,8 +1,16 @@
-set(HEADERS)
+set(HEADERS
+  module.h
+)
 set(CPPS
-  module.cpp)
+  module.cpp
+)
 
 add_library(module STATIC ${HEADERS} ${CPPS})
 target_link_libraries(module PRIVATE
   ddebug
 )
+target_include_directories(module PUBLIC
+  $<BUILD_INTERFACE:
+  ${PROJECT_SOURCE_DIR}/module
+  >
+)

netcon/descent3onlineclient/CMakeLists.txt

@@ -18,6 +18,7 @@ target_link_libraries(Descent3_Online_TCP_IP PRIVATE
   ddio
   inetfile
   misc
+  module
   ui
   $<$<PLATFORM_ID:Windows>:ws2_32>
 )

netcon/lanclient/CMakeLists.txt

@@ -11,6 +11,7 @@ target_link_libraries(Direct_TCP_IP PRIVATE
   ddio
   inetfile
   misc
+  module
   ui
   $<$<PLATFORM_ID:Windows>:ws2_32>
 )

netcon/mtclient/CMakeLists.txt

@@ -21,6 +21,7 @@ target_link_libraries(Parallax_Online PRIVATE
   ddio
   inetfile
   misc
+  module
   ui
   $<$<PLATFORM_ID:Windows>:ws2_32>
 )

netgames/dmfc/CMakeLists.txt

@@ -30,5 +30,6 @@ add_library(dmfc STATIC ${HEADERS} ${CPPS})
 target_link_libraries(dmfc PUBLIC
   grtext
   misc
+  module
   physics
 )

networking/CMakeLists.txt

@@ -15,6 +15,7 @@ target_link_libraries(networking PRIVATE
   ddio
   mem
   misc
+  module
   ${PLATFORM_LIBS}
   plog::plog
 )

networking/networking.cpp

@@ -290,6 +290,11 @@
 #include <process.h>
 #include <wsipx.h>
 #include <ras.h>
+
+#include "directplay.h"
+#include "dplay.h"
+#include "dplobby.h"
+
 typedef int socklen_t;
 #endif
 #include <stdlib.h>
@@ -311,36 +316,23 @@ typedef int socklen_t;
 #define LPSTR char *
 #endif
 
-#ifdef WIN32
-#include "dplay.h"
-#include "dplobby.h"
-#endif
-
 #include "descent.h"
 #include "appdatabase.h"
-
-#include "pstypes.h"
 #include "pserror.h"
 #include "log.h"
 #include "networking.h"
 #include "ddio.h"
 #include "mem.h"
+#include "module.h"
 #include "game.h"
 #include "args.h"
 #include "byteswap.h"
-
-#ifdef WIN32
-#include "directplay.h"
-#endif
-
 #include "pstring.h"
 
 #ifndef WIN32
 bool Use_DirectPlay = false;
 #endif
 
-#include "module.h" //for some nice defines to use below
-
 #define MAX_CONNECT_TRIES 50
 #define MAX_RECEIVE_BUFSIZE 32768
 //(1<<16)			// 16 K, eh?

physics/CMakeLists.txt

@@ -15,6 +15,7 @@ target_link_libraries(physics PRIVATE
   mem
   misc
   model
+  module
   rtperformance
   sndlib
   plog::plog

renderer/CMakeLists.txt

@@ -40,5 +40,6 @@ target_link_libraries(renderer PRIVATE
   ddio
   mem
   misc
+  module
   rtperformance
 )

scripts/CMakeLists.txt

@@ -79,6 +79,7 @@ foreach(SCRIPT ${SCRIPTS})
   target_link_libraries(${SCRIPT}
     fix
     misc
+    module
   )
   set_target_properties(${SCRIPT} PROPERTIES PREFIX "")
   set_target_properties(${SCRIPT} PROPERTIES CXX_VISIBILITY_PRESET "hidden")