mirror of
https://github.com/kevinbentley/Descent3.git
synced 2025-01-22 19:55:23 +00:00
d5e893fcb4
Before this change, cf_OpenLibrary() did something along the lines of this: char id[4]; fread(id, 4, 1, fp); strncmp(id, "HOG2", 4); If fread() finishes successfully, then that code is fine. However, fread() might encounter an error or bump into the end of a file. In those scenarios, the value of id will not necessarily be initialized [1]. In other words, when fread() fails, strncmp() might operate on uninitialized memory. This change makes sure that the value of id only gets used if fread() succeeds. Additionally, this change fixes a GCC warning about ignoring fread()’s return value. [1]: <https://en.cppreference.com/w/cpp/io/c/fread> |
||
---|---|---|
.. | ||
cfile.cpp | ||
cfile.h | ||
CMakeLists.txt | ||
hogfile.cpp | ||
hogfile.h | ||
inffile.cpp | ||
inffile.h |